Skip to content

Commit 3a139b6

Browse files
Merge pull request #929 from Codeinwp/bugfix/925
Fix update axis baseline color
2 parents 5425d59 + 5d15462 commit 3a139b6

File tree

6 files changed

+33
-290
lines changed

6 files changed

+33
-290
lines changed

classes/Visualizer/Gutenberg/build/block.js

Lines changed: 9 additions & 281 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/build/handsontable.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/build/handsontable.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

classes/Visualizer/Gutenberg/src/Components/Sidebar/HorizontalAxisSettings.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ const {
1818
TextControl
1919
} = wp.components;
2020

21+
import { getColorCode } from '../../utils.js';
22+
2123
class HorizontalAxisSettings extends Component {
2224
constructor() {
2325
super( ...arguments );
@@ -85,9 +87,9 @@ class HorizontalAxisSettings extends Component {
8587
label={ __( 'Base Line Color' ) }
8688
>
8789
<ColorPalette
88-
value={ settings.hAxis.baselineColor }
90+
value={ settings.vAxis.baselineColor }
8991
onChange={ e => {
90-
settings.hAxis.baselineColor = e;
92+
settings.vAxis.baselineColor = getColorCode( e );
9193
this.props.edit( settings );
9294
} }
9395
/>
@@ -100,7 +102,7 @@ class HorizontalAxisSettings extends Component {
100102
value={ settings.hAxis.textStyle.color || settings.hAxis.textStyle }
101103
onChange={ e => {
102104
settings.hAxis.textStyle = {};
103-
settings.hAxis.textStyle.color = e;
105+
settings.hAxis.textStyle.color = getColorCode( e );
104106
this.props.edit( settings );
105107
} }
106108
/>

classes/Visualizer/Gutenberg/src/Components/Sidebar/VerticalAxisSettings.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ const {
1818
TextControl
1919
} = wp.components;
2020

21+
import { getColorCode } from '../../utils.js';
22+
2123
class VerticalAxisSettings extends Component {
2224
constructor() {
2325
super( ...arguments );
@@ -85,9 +87,9 @@ class VerticalAxisSettings extends Component {
8587
label={ __( 'Base Line Color' ) }
8688
>
8789
<ColorPalette
88-
value={ settings.vAxis.baselineColor }
90+
value={ settings.hAxis.baselineColor }
8991
onChange={ e => {
90-
settings.vAxis.baselineColor = e;
92+
settings.hAxis.baselineColor = getColorCode( e );
9193
this.props.edit( settings );
9294
} }
9395
/>
@@ -100,7 +102,7 @@ class VerticalAxisSettings extends Component {
100102
value={ settings.vAxis.textStyle.color || settings.vAxis.textStyle }
101103
onChange={ e => {
102104
settings.vAxis.textStyle = {};
103-
settings.vAxis.textStyle.color = e;
105+
settings.vAxis.textStyle.color = getColorCode( e );
104106
this.props.edit( settings );
105107
} }
106108
/>

classes/Visualizer/Gutenberg/src/utils.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,3 +178,14 @@ export const getFormatterForGoogle = ( dataType ) => {
178178
}
179179
return null;
180180
};
181+
182+
export const getColorCode = ( color ) => {
183+
if ( -1 === color.indexOf( '#' ) ) {
184+
let getCssVar = color.match( /\((.*)\)/ ).pop();
185+
if ( getCssVar ) {
186+
let style = getComputedStyle( document.body );
187+
return style.getPropertyValue( getCssVar );
188+
}
189+
}
190+
return color;
191+
};

0 commit comments

Comments
 (0)