Skip to content

Fix update axis baseline color #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Fix update axis baseline color #929

merged 2 commits into from
Aug 29, 2022

Conversation

girishpanchal30
Copy link
Contributor

Close #925

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2022

Plugin build for 5d15462 is ready 🛎️!

@irinelenache
Copy link

@girishpanchal30 Tested and updating colors in block settings works fine, until the colors are selected from the Neve palette, can we do something about this?
You can check here:

https://visualizer.s1-tastewp.com/2022/08/23/test-line-chart-colors/
Username: irinel  
Password: s5pLLp6pFFw

@girishpanchal30
Copy link
Contributor Author

@irinelenache I have fixed the above mentioned issue. Please check with the latest commit.

@irinelenache
Copy link

@girishpanchal30 I checked now and the mentioned issue persists for me

@girishpanchal30
Copy link
Contributor Author

@irinelenache I think this issue persists due to the test instance file cache.
Can you please add the below PHP constant in the wp-config.php file to avoid file cache?
define( 'VISUALIZER_TEST_JS_CUSTOMIZATION', true );

It's working for me
Thanks

@irinelenache
Copy link

@girishpanchal30 Checked again and it's working fine now, thank you 🚀

@vytisbulkevicius
Copy link
Contributor

Hey @girishpanchal30,

Should we document this constant in our knowledgebase
define( 'VISUALIZER_TEST_JS_CUSTOMIZATION', true ); ?

Could you provide a bit of context what are the scenarios this could be happening to add it to the documentation?

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius

When we define this constant in the wp-config.php file it enqueues js with filetime in the ver query string instead of the plugin version.
Basically, this constant help to avoid server/browser file cache.

I hope you understood

Thanks

@vytisbulkevicius vytisbulkevicius merged commit 3a139b6 into development Aug 29, 2022
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.7.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 30, 2022
@selul selul deleted the bugfix/925 branch October 12, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line chart color options not working as expected. [in visualizer block options only]
4 participants