Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning when copy (frontend action) is enabled #949

Closed
irinelenache opened this issue Oct 19, 2022 · 3 comments · Fixed by #954 or #958
Closed

Warning when copy (frontend action) is enabled #949

irinelenache opened this issue Oct 19, 2022 · 3 comments · Fixed by #954 or #958
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@irinelenache
Copy link

Description:

When you enable the Copy feature in the frontend actions section, there will be a warning visible in frontend https://vertis.d.pr/i/rZvpDF

How to reproduce:

  1. Create a visualizer chart and add it to a post
  2. In editor, go to Advanced options > Frontend actions and enable Copy
  3. Check the chart in frontend

Expected behaviour:

There should be no warning

Current behaviour:

There is a warning in frontend

Reference:

https://vertis.d.pr/i/rZvpDF

Technical info

  • WordPress version: 6.0.3 / 6.1 RC2
  • Visualizer version: 3.8.1
  • Visualizer pro version: 1.11.1
@irinelenache irinelenache added the bug This label could be used to identify issues that are caused by a defect in the product. label Oct 19, 2022
girishpanchal30 added a commit that referenced this issue Oct 20, 2022
@girishpanchal30
Disable temp file creation error #949
c52e945
@girishpanchal30 girishpanchal30 mentioned this issue Oct 20, 2022
Merged
@girishpanchal30 girishpanchal30 linked a pull request Oct 20, 2022 that will close this issue
Fix PHP Warning #954
Merged
@girishpanchal30
Copy link
Contributor

Hey @irinelenache,
I can't reproduce this issue in my local and tastewp instances. Can you please check with the latest changes?

Thanks

@irinelenache
Copy link
Author

@girishpanchal30 Tested with your fix and the issue is fixed for me now, will move this to Ready to merge 🚀

@vytisbulkevicius vytisbulkevicius mentioned this issue Nov 4, 2022
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Nov 4, 2022 that will close this issue
Release #958
Merged
vytisbulkevicius added a commit that referenced this issue Nov 10, 2022
@vytisbulkevicius
release(minor): fixes and new features
ad22ce3 
- Fixed table chart decimal number issue Decimal Numbers are ignored and not displayed #955
- Fix the scrollbar issue that happens on WP 6.1 version [WP 6.1] Chart permissions selector is not scrollable #950
- Fix PHP Warning Warning when copy (frontend action) is enabled #949
- Compatibility with the WPML translation plugin for translating charts [PRO feature] add support for string translations #731
- Integration with Woocommerce Data endpoints for creating charts [PRO feature]
- Show new features on chart library page
pirate-bot pushed a commit that referenced this issue Nov 10, 2022
chore(release): 3.9.0
9607e8c 
#### [Version 3.9.0](v3.8.1...v3.9.0) (2022-11-10)

- Fixed table chart decimal number issue Decimal Numbers are ignored and not displayed [#955](#955)
- Fix the scrollbar issue that happens on WP 6.1 version [WP 6.1] Chart permissions selector is not scrollable [#950](#950)
- Fix PHP Warning Warning when copy (frontend action) is enabled [#949](#949)
- Compatibility with the WPML translation plugin for translating charts [PRO feature] add support for string translations [#731](#731)
- Integration with Woocommerce Data endpoints for creating charts [PRO feature]
- Show new features on chart library page
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PHP Warning Codeinwp/visualizer
Release Codeinwp/visualizer
3 participants
@pirate-bot @irinelenache @girishpanchal30