Updates for Zim 1.x #192
Merged
Updates for Zim 1.x #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changelog in https://github.com/zimfw/zimfw/blob/master/CHANGELOG.md Thanks a lot for chosing Zim as the Zsh framework of choice for your dotfiles and your courses! I spotted a few points where the usage is not compatible with the changes since Zim 1.0.0 (released 2020-01-07): * The zimfw repo is not intended to be cloned for daily use. You only need the zimfw.zsh file. And downloading it from https://github.com/zimfw/zimfw/releases/latest/download/zimfw.zsh will always give you the latest released version of it. * .zimrc should only contain module definitions, and it's not sourced anymore when the shell starts. * zhighlighters is deprecated in favor of ZSH_HIGHLIGHT_HIGHLIGHTERS, since we're using the zsh-users/zsh-syntax-highlighting module directly now. * There are two separate zimfw actions: `upgrade` will upgrade the zimfw.zsh file itself, and `update` will update the modules. You usually would want to do both if you want to "up" everything...
ericbn
commented
Nov 11, 2021
|
|
||
| zhighlighters=(main brackets) | ||
| zmodule zsh-users/zsh-syntax-highlighting | ||
| zmodule zsh-users/zsh-autosuggestions |
There was a problem hiding this comment.
It's recommended to source zsh-users/zsh-syntax-highlighting after completion. Likewise, zsh-users/zsh-autosuggestions goes better after zsh-users/zsh-syntax-highlighting.
| find "$DOTLY_PATH/modules/zimfw" -name '*.old' -exec rm -rf {} \; | ||
|
|
||
| /bin/zsh -c "source ${ZDOTDIR:-${HOME}}/.zlogin" | ||
| zsh "$ZIM_HOME/zimfw.zsh" clean-compiled && zsh "$ZIM_HOME/zimfw.zsh" compile |
There was a problem hiding this comment.
These two zimfw actions will do what you were doing before.
rgomezcasas
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola! 👋 Qué surpresa tan buena encontrar que a ustedes les gusta Zim y lo utilizan en su dotfiles y su curso de Zsh!
See changelog in https://github.com/zimfw/zimfw/blob/master/CHANGELOG.md
Thanks a lot for chosing Zim as the Zsh framework of choice for your dotfiles and your courses!
I spotted a few points where the usage is not compatible with the changes since Zim 1.0.0 (released 2020-01-07):
zhighlightersis deprecated in favor ofZSH_HIGHLIGHT_HIGHLIGHTERS, since we're using the zsh-users/zsh-syntax-highlighting module directly now.upgradewill upgrade the zimfw.zsh file itself, andupdatewill update the modules. You usually would want to do both if you want to "up" everything...