Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to ignore line count from deleted files? #66

Closed
OnkarRuikar opened this issue Jan 25, 2024 · 2 comments
Closed

Is it possible to ignore line count from deleted files? #66

OnkarRuikar opened this issue Jan 25, 2024 · 2 comments

Comments

@OnkarRuikar
Copy link
Contributor

Thank you for the such an useful tool!

We have implemented it in mdn/content. In this PR only files were deleted, we use a custom command to deletions so there was almost no effort reviewing the PR.

But the PR got the biggest size label size/xl. Is is possible to ignore lines from deleted files?
@OnkarRuikar OnkarRuikar mentioned this issue Jan 25, 2024
Closed
@johnlk johnlk mentioned this issue Apr 8, 2024
Closed
@johnlk
Copy link
Collaborator

johnlk commented Apr 13, 2024

Love this idea! Agreed. At least providing an option like ignore_deletions: false which is false by default

This was referenced Apr 14, 2024
Merged
Merged
@johnlk
Copy link
Collaborator

johnlk commented May 12, 2024

Addressed in #76 🤞🏻

@johnlk johnlk closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnlk @OnkarRuikar