Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring file deletions #76

Merged
merged 4 commits into from
May 14, 2024
Merged

Support ignoring file deletions #76

merged 4 commits into from
May 14, 2024

Conversation

johnlk
Copy link
Collaborator

@johnlk johnlk commented Apr 17, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This change supports ignoring files which are wholly deleted. This seems to be a common ask. The new config variable is called ignore_file_deletions and relies on the files API to determine the status of a file.

This change was inspired by #61 , but with updated patterns and tests.

How to test

I added unit tests for the new code paths to ensure everything is behaving as expected.

Link to issues addressed

@johnlk johnlk self-assigned this Apr 17, 2024
@johnlk johnlk force-pushed the john/ignore-file-deletions branch from 5b02d25 to e022e7b Compare April 17, 2024 00:05
@johnlk johnlk marked this pull request as ready for review April 17, 2024 00:06
@johnlk johnlk requested a review from JavierCane April 17, 2024 00:06
@johnlk
Copy link
Collaborator Author

johnlk commented Apr 17, 2024

cc: @OnkarRuikar

src/github.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@JavierCane JavierCane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnlk, gooooooood work 🎉 🙌

  1. I have taken the freedom to commit some README.md changes in the branch instead of making them as a PR comment suggestions because GitHub does not allow me to do so due to implying some non-modified lines 😬

    Feel free to discuss any concern regarding the changes 🙏😇

  2. Regarding the inspiration on Implementation for ignore_deleted option #61, I completely understand that, given the modifications in the project since that PR it is easier to implement it in a new PR (my fault on not reviewing them on time). However, I would propose to add @rwyland
    as the merge commit co-author in order to give him credit for the contribution 😊

    Taking a look to his contributions to other public repositories, it would be just by adding the following to the merge commit:

    
    Co-authored-by: Rob W <rlw0788@gmail.com>
    

johnlk and others added 3 commits May 14, 2024 09:10
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
@johnlk johnlk force-pushed the john/ignore-file-deletions branch from 044d140 to bcadc34 Compare May 14, 2024 13:10
…he most related arguments to make it easier to read

Improve the existing contribution guide (#74)

* Improve the existing contribution guide

* reorder the contribution steps to push testing up

Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com>

* tweak contribution process opener copy

Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com>

---------

Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com>

Put back accidental deletion
@johnlk johnlk force-pushed the john/ignore-file-deletions branch from bcadc34 to a0cfd49 Compare May 14, 2024 13:11
@johnlk johnlk merged commit cc6827c into main May 14, 2024
2 checks passed
@johnlk johnlk deleted the john/ignore-file-deletions branch May 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants