Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make connection URL configurable #23

Closed
wants to merge 1 commit into from
Closed

Make connection URL configurable #23

wants to merge 1 commit into from

Conversation

sta-szek
Copy link

@sta-szek sta-szek commented Mar 3, 2021

This PR will reuse variables GITHUB_API_URI and GITHUB_API_HEADER if they are already defined.

@mambax
Copy link
Contributor

mambax commented Mar 3, 2021

hehe @sta-szek I contributed that yesterday #22

@sta-szek
Copy link
Author

sta-szek commented Mar 3, 2021

I missed that, sorry for confusion 🙇

@sta-szek sta-szek closed this Mar 3, 2021
@JavierCane
Copy link
Member

Hi @sta-szek, thanks for your contribution in any case!

We did a release a few hours ago including the parameter added by @mambax. However, it did not expose anything regarding the HTTP Headers. Is there any use case we would be missing not supporting it?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sta-szek @mambax @JavierCane