Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Maps should not be shipped in NPM package #1503

Closed
1 task done
Danielku15 opened this issue May 20, 2024 · 0 comments · Fixed by #1540
Closed
1 task done

Source Maps should not be shipped in NPM package #1503

Danielku15 opened this issue May 20, 2024 · 0 comments · Fixed by #1540
Assignees
@Danielku15
Labels
area-core Related to some core parts of alphaTab platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Milestone
1.4.0

Comments

@Danielku15
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Follow up of #1502

The NPM package contains source maps redirecting from the correct alphaTab output back to the typescript sources. This leads to problem in tooling and debugging where these files are not available.

Expected Behavior

The source maps should not be part of the NPM package.

Steps To Reproduce

  1. Look into the 1.3.0 package where the dist/**.js.map files are
  2. Inspect the source maps and notice the reference to typescript files.

Link to jsFiddle, CodePen, Project

#1502

Found in Version

1.3-alpha

Platform

Web

Environment

Irrelevant

Anything else?

No response
@Danielku15 Danielku15 added the state-needs-triage Bug not triaged yet. label May 20, 2024
@Danielku15 Danielku15 self-assigned this May 20, 2024
@Danielku15 Danielku15 mentioned this issue May 20, 2024
Closed
1 task
@Danielku15 Danielku15 added 🕷️ type-bug state-accepted This is a valid topic to work on. platform-javascript Related to the JavaScript version of alphaTab area-core Related to some core parts of alphaTab and removed state-needs-triage Bug not triaged yet. labels Jun 2, 2024
@Danielku15 Danielku15 moved this to Todo in alphaTab 1.4-1.x Jun 2, 2024
@Danielku15 Danielku15 mentioned this issue Jun 15, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in alphaTab 1.4-1.x Jun 15, 2024
@Danielku15 Danielku15 added this to the 1.4.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-core Related to some core parts of alphaTab platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Projects
alphaTab 1.4-1.x
Status: Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

fix: Source Maps should not be shipped in NPM package CoderLine/alphaTab
1 participant
@Danielku15