Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Source Maps should not be shipped in NPM package #1540

Merged
merged 1 commit into from
Jun 15, 2024
Merged

fix: Source Maps should not be shipped in NPM package #1540

merged 1 commit into from
Jun 15, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1503

Proposed changes

Do not pack source maps to NPM package, they reference the TS files not shipped in the package.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jun 15, 2024
@Danielku15 Danielku15 enabled auto-merge (squash) June 15, 2024 15:44
@Danielku15 Danielku15 merged commit 273246a into develop Jun 15, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/remove-sourcemaps branch June 15, 2024 15:49
Danielku15 added a commit that referenced this pull request Jun 15, 2024
@Danielku15
fix: Source Maps should not be shipped in NPM package (#1540)
f5eb128
@Danielku15 Danielku15 mentioned this pull request Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Maps should not be shipped in NPM package
1 participant
@Danielku15