Loud clipping sound when playback ends #1599
Comments
Danielku15
added
🕷️ type-bug
state-accepted
|
To make the repro simpler, here is an 1 file example. I just tweaked it until I could repro. I added a bunch of random garbage dom nodes (to impact performance a bit), and that made it consistently reproducible. I don't know if the config (notation/display settings) have anything to do with it, couldn't really find a consistent answer for that, so I just added the stuff I have. <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>AlphaTab Click/Pop repro</title>
<script src="https://cdn.jsdelivr.net/npm/@coderline/alphatab@alpha/dist/alphaTab.min.js"></script>
</head>
<body>
<div id="alphaTab"></div>
<div id="garbage" style="display: flex; flex-wrap: wrap"></div>
<button onclick="api.playPause()">Play/Pause</button>
<script type="text/javascript">
const alphaTabDom = document.querySelector('#alphaTab')
const score = `\\track "Bass" "Bass" \\instrument "AcousticBass"
\\clef Bass \\ts 4 4 \\ks C 0.3.4 4.3.4 2.2.4 4.3.4 | 5.3.1`
const api = new alphaTab.AlphaTabApi(alphaTabDom, {
core: { tex: true, engine: 'svg' },
notation: { elements: { guitarTuning: false, trackNames: false } },
display: {
staveProfile: 'Default',
justifyLastSystem: true,
barsPerRow: 4,
resources: {},
},
player: {
enableCursor: true,
enableAnimatedBeatCursor: true,
enableElementHighlighting: true,
enablePlayer: true,
enableUserInteraction: true,
soundFont:
'https://cdn.jsdelivr.net/npm/@coderline/alphatab@latest/dist/soundfont/sonivox.sf2',
},
})
api.tex(score)
// Adding a bunch of garbage to the dom, to make the browser work a bit
const garbage = document.getElementById('garbage')
for (let i = 0; i < 20000; i += 1) {
const el = document.createElement('div')
el.style.width = '1px'
el.style.height = '1px'
el.style.backgroundColor =
'#' + Math.floor(Math.random() * 16777215).toString(16)
garbage.appendChild(el)
}
</script>
</body>
</html> |
|
Thanks a lot for your efforts. I hope this allows narrowing down the problem easier. I have a lot going on in private life currently and don't find a lot of time to develop on alphaTab. But I'll try to tackle this as one of the next things. |
|
No worries, just wanted to make a repro, so tracking this down is not find Waldo in my code :) Hope all will be good in your private life mate! |
|
@bali182 Can you check if things are improving with |
|
Just updated, and it seems miles better on my end too. There is a little pop at the end, but that might just be because of the envlelope of the note, no loud cracks/clicks, well done! 👍 |
|
|
Is there an existing issue for this?
Current Behavior
When the playback ends there is a chance of hearing some (clipping) noise at the end.
Expected Behavior
No clipping noise should occur, not on the first and not on second/third playbacks.
Steps To Reproduce
Link to jsFiddle, CodePen, Project
https://bali182.github.io/stick/#/default/score
Found in Version
1.4 (alpha)
Platform
Web
Environment
Anything else?
#1593
#1298
The text was updated successfully, but these errors were encountered: