Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure smooth synth ending #1609

Merged
merged 1 commit into from
Aug 11, 2024
Merged

fix: Ensure smooth synth ending #1609

merged 1 commit into from
Aug 11, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1599

Proposed changes

We currently have a hard stop when we reach the end of the song. This leads to a cut-off on the samples and results in weird clicking noises. This PR changes the stop sequence of the synthesizer to:

  1. Request a fast stop of all voices being played (not instantly)
  2. Waiting for all voices to really stop providing samples before finishing

This way we have a smooth ramp-down of the audio (still fast though).

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 11, 2024
@Danielku15 Danielku15 merged commit 9eb30aa into develop Aug 11, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/no-hard-stop branch August 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loud clipping sound when playback ends
1 participant