Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect Band paddings are kept on line breaks during initial render #1611

Closed
1 task done
goodgame365 opened this issue Aug 12, 2024 · 0 comments · Fixed by #1621
Closed
1 task done

Effect Band paddings are kept on line breaks during initial render #1611

goodgame365 opened this issue Aug 12, 2024 · 0 comments · Fixed by #1621
Assignees
@Danielku15
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.

Comments

@goodgame365
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

the bug like this img:
未标题-1

Expected Behavior

I hope to display it like Guitar Pro 8.

未标题-2

Steps To Reproduce

It happens when these two adjacent bars are not in the same row.
test.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

Operating System: Mobile and PC
Browser: Chrome 92.0.4515.159

Anything else?

No response
@goodgame365 goodgame365 added the state-needs-triage Bug not triaged yet. label Aug 12, 2024
@goodgame365 goodgame365 changed the title I found a serious bug: the current bar will inherit the height value of the bar that is in a different row. I found a serious bug: the current bar will inherit the height value of the bar(nextbar) that is in a different row. Aug 12, 2024
@Danielku15 Danielku15 changed the title I found a serious bug: the current bar will inherit the height value of the bar(nextbar) that is in a different row. Effect Band paddings are kept on line breaks during initial render Aug 16, 2024
@Danielku15 Danielku15 added type-bug 🕷️ area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Aug 16, 2024
@Danielku15 Danielku15 mentioned this issue Aug 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure correct effect band sizing on bar reverts CoderLine/alphaTab
2 participants
@Danielku15 @goodgame365