Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure correct effect band sizing on bar reverts #1621

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1611

Proposed changes

Re-compute the effect band sites during bar reverts to have correct paddings according to final setup.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 16, 2024
@Danielku15 Danielku15 merged commit 996d08a into develop Aug 16, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/effect-band-padding branch August 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effect Band paddings are kept on line breaks during initial render
1 participant