Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stave Profiles do not respect visible staffs correctly #1656

Closed
1 task done
Danielku15 opened this issue Aug 31, 2024 · 0 comments · Fixed by #1657
Closed
1 task done

Stave Profiles do not respect visible staffs correctly #1656

Danielku15 opened this issue Aug 31, 2024 · 0 comments · Fixed by #1657
Assignees
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.

Comments

@Danielku15
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The current logic of having stave profiles doesn't match well the model definition which staves to show.
With slash and numbered notation added not all combinations of staffs have a proper profile to choose from.

This can lead in errors on rendering as we cannot find a matching profile and wrong or no bar renderers are created.

Expected Behavior

On the default mode (no custom stave profile) the respective renderers should be created based on the model information.

Steps To Reproduce

  1. Create a file with only Jianpu or Slash and try to render it.

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

Irrelevant

Anything else?

@Danielku15 Danielku15 added type-bug 🕷️ area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms labels Aug 31, 2024
@Danielku15 Danielku15 self-assigned this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant