Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rework StaveProfile definitions #1657

Merged
merged 3 commits into from
Aug 31, 2024
Merged

refactor: rework StaveProfile definitions #1657

merged 3 commits into from
Aug 31, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1656

Proposed changes

This PR

  • Unifies the stave profile definitions to have a similar rendering experience when hiding staffs and switching to specific staff profiles.
  • Avoid duplicate glyphs (time signatures etc.) in new staves
  • Fixed some other rendering disturbances on the way.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 31, 2024
@Danielku15 Danielku15 merged commit dd504e7 into develop Aug 31, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/stave-profile branch August 31, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stave Profiles do not respect visible staffs correctly
1 participant
@Danielku15