You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discovered an error in the changes made in commit 03a6cbc5a5187e90f265b11841854afd9cfe7c54. The issue is that the scaling factor was not added to the symbol:
#1755
Closed
goodgame365 opened this issue
Nov 16, 2024
· 1 comment
· Fixed by #1772
I discovered an error in the changes made in commit 03a6cbc. The issue is that the scaling factor was not added to the symbol:
at:\src\rendering\glyphs\SustainPedalGlyph.ts
if (marker.pedalType === SustainPedalMarkerType.Down) { canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalPed, true); linePadding = (SustainPedalGlyph.TextWidth / 2) * this.scale + SustainPedalGlyph.TextLinePadding * this.scale; } else if (marker.pedalType === SustainPedalMarkerType.Up) { canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalUp, true);
In this part, the line:
canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalPed, true);
should be changed to:
canvas.fillMusicFontSymbol(markerX, y + h, this.scale, MusicFontSymbol.KeyboardPedalPed, true);
Similarly, the latter part should also change 1 to this.scale.
Originally posted by @goodgame365 in #1753
The text was updated successfully, but these errors were encountered: