refactor: Handle scaled rendering at canvas and layout level #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
force-pushed
the
feature/rework-scale-handling
branch
from
551eef0 to
ec5704c
Compare
Danielku15
force-pushed
the
feature/rework-scale-handling
branch
from
ec5704c to
f68e72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1755
Proposed changes
Instead of handling scaled rendering across all glyphs and in the bar renderer we now handle scaling on canvas and layout level.
All glyphs and bar renderers work on a scale=1 basis and on canvas level the scaling is applied automatically. Some things are handled on layout level to ensure we have a correct fit.
Also the bounds lookup is adjusted accordingly.
This fixes all inconsistent scale handlings that were hidden.
Checklist
Further details