Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Handle scaled rendering at canvas and layout level #1772

Merged
merged 12 commits into from
Nov 24, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1755

Proposed changes

Instead of handling scaled rendering across all glyphs and in the bar renderer we now handle scaling on canvas and layout level.

All glyphs and bar renderers work on a scale=1 basis and on canvas level the scaling is applied automatically. Some things are handled on layout level to ensure we have a correct fit.

Also the bounds lookup is adjusted accordingly.

This fixes all inconsistent scale handlings that were hidden.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 24, 2024
@Danielku15 Danielku15 marked this pull request as ready for review November 24, 2024 18:29
@Danielku15 Danielku15 force-pushed the feature/rework-scale-handling branch from 551eef0 to ec5704c Compare November 24, 2024 19:03
@Danielku15 Danielku15 force-pushed the feature/rework-scale-handling branch from ec5704c to f68e72a Compare November 24, 2024 19:21
@Danielku15 Danielku15 merged commit cff6195 into develop Nov 24, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/rework-scale-handling branch November 24, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant