Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bend with Hammer/Pull bug #1825

Closed
1 task done
kirnuarp opened this issue Jan 21, 2025 · 1 comment · Fixed by #1844
Closed
1 task done

Bend with Hammer/Pull bug #1825

kirnuarp opened this issue Jan 21, 2025 · 1 comment · Fixed by #1844
Assignees
Labels
area-player Related to the audio playback engine. platform-all Affects all platforms state-accepted This is a valid topic to work on.

Comments

@kirnuarp
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Image

bend_hp_bug.gp.zip
soundFont: "/font/sonivox/sonivox.sf2"

there's no audible pitch bend from the note which is bent.

Expected Behavior

The note should have audible pitch bend of 3/4 full steps

Steps To Reproduce

1.Load attached .gp file with playground/control.mjs
2.Refresh your browser page and play the file

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

- **OS**:
- **Browser**:
- **.net Version**:

Anything else?

No response

@kirnuarp kirnuarp added the state-needs-triage Bug not triaged yet. label Jan 21, 2025
@Danielku15 Danielku15 added type-bug 🕷️ state-accepted This is a valid topic to work on. area-player Related to the audio playback engine. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Feb 8, 2025
@Danielku15
Copy link
Member

Fixing notes: We move notes to the secondary midi channel in case of some effects so that the notes do not interfere with others. This behavior is adopted from GuitarPro. In this case the original note is placed on the primary channel due to this logic, but then on the tied note we just adjust the pitch bend (on the secondary channel). We should calculate the channel as part of getNoteDuration where we can respect all involved notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants