Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong bend pitches on tied notes #1844

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1825

Proposed changes

  • Fixes a problem where midi pitch bend events would be send to the wrong channel by ensuring we use the same channel across tied notes.
  • Fixes an inaccuracy problem on generated bends for the bend-end which could cause wierd wobbles on bends which should not be there.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Feb 9, 2025
@Danielku15 Danielku15 merged commit fa2ed47 into develop Feb 9, 2025
4 checks passed
@Danielku15 Danielku15 deleted the feature/fix-tied-bend branch February 9, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bend with Hammer/Pull bug
1 participant