Bend tied vibrato bug

[kirnuarp]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

AlphaTab:

GuitarPro:

bend_tied_vibrato_bug.gp.zip
soundFont: "/font/sonivox/sonivox.sf2"

-The bend is drawn wrongly. It doesn't match the note in the note bar.
-It would be good if the tied note would be also drawn like guitar pro does
-There is no audible vibrato played

Expected Behavior

-The bend should end where the tied note starts.
-There should be audible vibrato played when the tied note starts

Steps To Reproduce

1.Load attached .gp file with playground/control.mjs
2.Refresh your browser page and play the file

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha)

Platform

Web

Environment

- **OS**:
- **Browser**:
- **.net Version**:

Anything else?

No response

[Danielku15]

(rendering): The problem likely comes from the extendBendArrowsOnTiedNotes setting. For some reason it is extending the arrow in this file even though it shoudln't. We likely need to ensure also that the vibrato is moved when the setting is really active causing the wierd display in first place. This part is really a bug.

(audio): My initial assumption below as wrong. We do not have vibrato and bends on the same note in this situation. The vibrato is on the second tied note which should result in correct generation. But there is indeed rather a combined bug here, the behavior should be:

1. The bend effect needs to "complete" on the tied note when there is a vibrato.
2. The generated vibrato wave must start at the pitch where the bend ends (not the normal note pitch)

outdated

(audio): We currently do not support combined bends and vibratos. Similarly [other effects](https://github.com/CoderLine/alphaTab/blob/c99ea3de764d65d114ef9edd4ea8a581eef29d23/src/midi/MidiFileGenerator.ts#L547-L559) cannot be combined at this point. This part is currently rather a known limitation / missing feature and not a bug. We should check of GP is generating the audio in this case. Technically it should be no big deal to generate vibratos at the "end" of the bend, we need to respect the correct pitch bend and bend duration. But we have to check how we "slice" the total play duration into bend and vibrato in this situation. The vibrato is placed on the tied note marking the start of the vibrato but internally also the "bend points positions" mark when the bend completes. Physically (and technically in alphaTab) bends and vibrato are the same thing: a change of the note pitch.