Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bend tied vibrato bug #1843

Merged
merged 3 commits into from
Feb 9, 2025
Merged

fix: Bend tied vibrato bug #1843

merged 3 commits into from
Feb 9, 2025

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1826

Proposed changes

  • Fixes the wrong bend line placement of arrows in bend+tied+vibrato combinations.
  • Improves the vibrato placement on bend+tied+vibrato combinations (tab bend glyph will draw them instead of the effect bar renderer)
  • Fixes the wrong pitch bend generation for bend+tied+vibrato combinations

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Feb 9, 2025
@Danielku15 Danielku15 merged commit 0840742 into develop Feb 9, 2025
4 checks passed
@Danielku15 Danielku15 deleted the feature/bend-tied-vibrato branch February 9, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bend tied vibrato bug
1 participant
@Danielku15