Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: right is undefined #648

Closed
2 tasks
garthholmes opened this issue Aug 16, 2021 · 3 comments · Fixed by #651
Closed
2 tasks

TypeError: right is undefined #648

garthholmes opened this issue Aug 16, 2021 · 3 comments · Fixed by #651
Assignees
Labels
area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.

Comments

@garthholmes
Copy link

garthholmes commented Aug 16, 2021

Expected Results

AlphaTab should play, as normal.

Observed Results

AlphaTab, does not play and produces an error, line in code is as follows:

let samples = left.length + right.length;

Steps to Reproduce

Press play

Further details

All versions above and including v1.3.0-alpha.125 do not produce sound.

v1.3.0-alpha.125 produces an error, all other aforementioned versions produce no error.

Your environment

Version

  • 1.3-alpha.125 and above

Flavor

  • JavaScript

System

Firefox (Windows 10)

@Danielku15
Copy link
Member

Please double check really the latest version. #645 should have fixed this already. Considering this change I don't believe that this should be still an issue in alpha.127

@garthholmes
Copy link
Author

garthholmes commented Aug 16, 2021

Hi Daniel,

I was using alpha.115 and thought I would upgrade, which I do periodically.

I have updated the example, to v127 but the problem still persists in FireFox.

If it makes any difference, I am using a Service Worker in the website but that's about all I can say regarding the situation other than to add that once play is pressed, besides there being a delay in Chrome (Chrome does produce sound), with respect to previous versions of the library; I can however click on individual notes in FireFox, with the notes in the bass clef being highlighted as if the music is playing but alas it is not, and no error message is shown, which is why I went as far as I could, i.e. to alpha.125.

Regards

@Danielku15
Copy link
Member

v128 is in the pipe and should fix the output problems on Firefox. But there seem to be still cursor flickering issues I have to address separately.

Regarding your long delay: It is your server which is really slow and has caching disabled. Every time a worker or a audio worklet again a download of the 1.8MB (unminimized) alphaTab starts. You might want to check your webserver settings to allow caching of the related files to speed up the playback:
image

The script processor was feeling faster because the download of the file for the worker happened already on page load. But the audio worklet download only starts upon play. If nothing is cached, this causes a delay in playback start.

@Danielku15 Danielku15 added area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on. and removed state-needs-investigation labels Aug 16, 2021
@Danielku15 Danielku15 added this to the [v1.3.0] Audio Worklets milestone Nov 4, 2021
@Danielku15 Danielku15 moved this to Done in Version 1.3 Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants