Adjust ui element positioning to support browser scaling #1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes wrong cursor placement when using browser zoom (detected as part of 1.2.3 testing)
Proposed changes
The problem with 1x1px elements being scaled using transforms is the order how the browser applies the browser zoom (not pinch zoom). First the 1x1px element is scaled to the zoom level and then the scale is applied. on a 1x1px element, it will stay a 1x1px element on the browser zoom because on those pixel sized elements no fractions are possible. Then the scale is applied keeping the element always on the 100% zoom level not matching the music sheet.
As a fix we use now a 100x100px element for cursors and selections which is then scaled correctly. This way the 100x100px element gives us enough zoom options to scale along the browser zoom.
Checklist
Further details