Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong reading of alternate endings in GP5 #1028

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1023

Proposed changes

There was an error in the handling of alternate endings reading for GP5 files which can lead to 1 byte read to much.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 1, 2022
@Danielku15 Danielku15 merged commit 7c80058 into develop Nov 1, 2022
@Danielku15 Danielku15 deleted the feature/gp5-import-error branch November 1, 2022 14:26
ChiHoc pushed a commit to ChiHoc/alphaTab that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The file could not be loaded due to an error.
1 participant