Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust grace positioning to utilize free space #1094

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jan 14, 2023

Issues

Fixes #1093

Proposed changes

  1. Ensures we uniquely store beat sizes in the BarLayoutingInfo by utilizing the id instead of index.
  2. Utilize the PreBeatSize of the Beat after the grace notes to compute the position of the grace notes allowing them to be placed closer to the note if the space is unused.
  3. Ensure the ScoreBrushGlyph doesn't consume any space if nothing is rendered

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 14, 2023
@Danielku15 Danielku15 merged commit a055034 into develop Jan 14, 2023
@Danielku15 Danielku15 deleted the feature/grace-empty-space branch January 14, 2023 19:43
@goodgame365
Copy link

Great, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grace Notes should utilize the empty pre-beat space
2 participants