Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate render requests of partials #1148

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Prevent duplicate render requests of partials #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/platform/javascript/BrowserUiFacade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,13 @@ export class BrowserUiFacade implements IUiFacade<unknown> {
// missing result or result not matching layout -> request render
if (placeholder.renderedResultId !== placeholder.layoutResultId) {
if (this._resultIdToElementLookup.has(placeholder.layoutResultId!)) {
this._api.renderer.renderResult(placeholder.layoutResultId!);
if(placeholder.resultState !== ResultState.RenderRequested) {
Logger.warning('Rendering', 'Outside Request render of lazy partial ' + placeholder.layoutResultId!);
placeholder.resultState = ResultState.RenderRequested;
this._api.renderer.renderResult(placeholder.layoutResultId!);
} else {
// Already requested render of this partial, wait for result
}
} else {
htmlElement.replaceChildren();
}
Expand Down