Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for chords in MusicXML importer #1299

Merged
merged 5 commits into from
Dec 9, 2023
Merged

Adds support for chords in MusicXML importer #1299

merged 5 commits into from
Dec 9, 2023

Conversation

coluzziandrea
Copy link
Contributor

Issues

Fixes #667

image

Proposed changes

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@coluzziandrea
Copy link
Contributor Author

Hi @Danielku15, could you please take a look at this PR? 😊

Copy link
Member

@Danielku15 Danielku15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this change and sorry for the delay. I currently have not much time to work on alphaTab.

Can you maybe also take care that the C# variant compiles?

@coluzziandrea
Copy link
Contributor Author

@Danielku15 I've addressed comments, take a look when you have time please

@Danielku15 Danielku15 merged commit df4ce14 into CoderLine:develop Dec 9, 2023
@Danielku15
Copy link
Member

@coluzziandrea Thanks a lot for your contribution. I took care of the remaining updates and cross compilation bits.

@goodgame365
Copy link

But after the update. the exported GP format file cannot be opened in Guitar Pro 8. When I try to open it, Guitar Pro 8 crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for chord diagrams in MusicXML
3 participants