Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend webpack plugin for supporting contenthash #1395

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1348

Proposed changes

  • Better handling of non-web files
  • Ensure webpack dependencies can be serialized and the runtime is cached (needed for hot reload)
  • Splitup of webpack plugin into multiple files for better code structure
  • Ensure font and soundfont assets are registered within webpack (required for dev server)
  • Do lookup of worklet chunk files during runtime and add runtime module for accessing file names (required for contenthash)

Tested with the alphaTab website.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Mar 3, 2024
@Danielku15 Danielku15 merged commit 9ce94fb into develop Mar 3, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/webpack-contenthashes branch March 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full WebPack support
1 participant