Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Use webpack instance passed to plugin #1539

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1523
Fixes #1522

Proposed changes

Reorganizes the WebPack plugin to fix and improve following parts:

  • Use the WebPack provided to the plugin instead of importing it. This ensures allows usage in environments like nextjs where WebPack is hidden from the user and not shipped as NPM package.
  • We use the officially exposed APIs only and don't need to access internals through paths.
  • The detection of entry points in the webpack runtime plugin is now using some prefix to survive recompilation when the main files are not touched.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jun 15, 2024
@Danielku15 Danielku15 merged commit 42612e2 into develop Jun 15, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/nextjs branch June 15, 2024 15:43
@Danielku15 Danielku15 mentioned this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing the alphaTab WebPack plugin in ESM fails.
1 participant