Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple tempo changes in bar #1600

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #815

Proposed changes

Adds the support for multiple tempo changes within a bar. The changes are positioned relatively within the bar and not necessarily attached to a beat.

  • Rendering is done relatively to the width of the space where notes are placed in the ba (aligns with the display of guitar pro)
  • The calculation of cursor transition duration is a bit more expensive in such cases, but we have a fast path for the simple old setup.
  • Audio generation is fairly simple as we're using ticks which are tempo independent.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 3, 2024
@Danielku15 Danielku15 merged commit 04ef15b into develop Aug 3, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/multi-tempochange branch August 3, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play multiple tempos in a masterbar
1 participant