Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add numbered notation (Jianpu) #1628

Merged
merged 10 commits into from
Aug 24, 2024
Merged

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Aug 17, 2024

base renderer + number and accidental calculation

Issues

Fixes #1505

Proposed changes

Adds renderers for numbered notations.

  • Base Renderer added
  • Rendering of 'key signature' ( 1 = xxx )
  • Rendering of correct accidentals
  • Rendering of correct numbers
  • Rendering of effects (dead notes, ties,..)
  • Rendering of note octave
  • Rendering of note durations (dots, lines and tuplets)
  • Extend test suite

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

base renderer + number and accidental calculation
@Danielku15 Danielku15 self-assigned this Aug 17, 2024
@Danielku15 Danielku15 marked this pull request as ready for review August 24, 2024 10:23
@Danielku15 Danielku15 merged commit 5ce48a2 into develop Aug 24, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/numbered-notation branch August 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbered Notation
1 participant