Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement new bracket/braces/system rendering #1730

Merged
merged 12 commits into from
Nov 3, 2024

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 3, 2024

Issues

Fixes #1697

Proposed changes

  • Add reading of the bracket mode from Guitar Pro files
  • Add bracket and braces rendering folowing Guitar Pro logic
  • Read system separator sign setting from Guitar Pro files
  • Add system separator rendering

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 3, 2024
@Danielku15 Danielku15 marked this pull request as ready for review November 3, 2024 21:22
@Danielku15 Danielku15 merged commit c299b20 into develop Nov 3, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/brackets-braces branch November 3, 2024 22:03
@Danielku15 Danielku15 linked an issue Nov 10, 2024 that may be closed by this pull request
11 tasks
@Danielku15 Danielku15 removed a link to an issue Nov 10, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust display of braces and brackets
1 participant