Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various release testing problems #1910

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Conversation

Danielku15
Copy link
Member

Proposed changes

Fixes various smaller problems detected during writing documentation and release testing.

  • alphaTex allows now the use of double backslash on meta commands making it easier to copy-paste alphaTex from and to source code strings.
  • Some types of the data models and settings were not publicly exposed making it hard to use them in TypeScript.
  • Fixed a problem that beat timers were only shown for the first beat of a bar.
  • Fixed a problematic alignment of dead slap beats
  • Fixed wrong placement of the playback cursor for simile marked bars
  • Ensure the SettingsJson type is used on fillToJson
  • Fixed a wrong scrollTop used (dead code but it was still wrong).

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Feb 19, 2025
@Danielku15 Danielku15 merged commit 67044a0 into develop Feb 19, 2025
4 checks passed
@Danielku15 Danielku15 deleted the feature/minor-release-fixes branch February 19, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant