Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spacing and alignment problems #1915

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

Danielku15
Copy link
Member

Proposed changes

Discovered during testing and adaptions of the BoundsLookup. Various alignment aspects were somehow broken:

  • Ensure cursor is aligned on onNoteX (aka. onTimeX) - the X-position where a certain beat is playing according to the timely distribution.
  • Fixed alignment in TripletFeel rendering by using SmuFl items to build the bars.
  • Fully removed scaling of preBeat and onBeat glyphs across renderers which lead to wrong positions of onNoteX and generally beat container glyphs.
  • Updated test suite after latest changes (some files were missed)
  • Updated the EffectBarRenderer to use BarLayoutingInfo instead of glyph sizes (as we do not scale them anymore)
  • Adjusted (again) the aligning of Grace Beats as this was influenced by the other changes.
  • Optimized some Slide glyph alignments after beat glyph scaling changes.
  • Fixed BoundsLookup for Systems
  • Reworked the visual tests to be more flexible regarding testing options (new render callback needed for bounds lookup tests)

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Feb 26, 2025
@Danielku15 Danielku15 force-pushed the feature/fix-positioning branch 8 times, most recently from 7030da7 to b63042a Compare February 26, 2025 02:05
@Danielku15 Danielku15 force-pushed the feature/fix-positioning branch from b63042a to 251c69a Compare February 26, 2025 02:06
@Danielku15 Danielku15 merged commit 25caa38 into develop Feb 26, 2025
4 checks passed
@Danielku15 Danielku15 deleted the feature/fix-positioning branch February 26, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant