Fixed jumping on cursor for multi staff setups #324
Merged
+57
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
added a commit
that referenced
this pull request
Jul 25, 2020
* Package all JavaScript files on build * Added click listener to attempt resume of audio context if not running (fixes #200), Added patch for iOS to potentially initialize correct sample rate * Added catch for zip file (Haxe throws string) * Improved handling of Tied notes for MusicXML * Corrected audio generation for grace notes * Added additional output activation to start audio context in Browsers * Reworked staff display to respect GP file contents * Parse PartConfig also for GPX files * Added chord diagram rendering to page layout * Added chord support to alphaTex * Fixed compilation issues * Fixed wrong error message for tuning change * Bump version number * Bump version number in appveyor * Update alphaTex chord documentation * Added IDs to headings for better linking * Fixed rhythm notation positioning * Fixed issue on tied notes causing stack-overflow * Fixed issue in alphaTex importer that notes were added to a beat before it is known whether it is stringed * Introduced consistent API across all platforms, integrated alphaSynth into .net version * Added support for multiple tracks and staffs in alphaTex #207 * Fixed null reference for new "all" track rendering * Added short track name reading to alphaTex and made track names optional #207 * Rebuild * Updated documentation with new "all" tracks and multi-staff/track alphaTex features #207 * Attempt to make appveyor push back version number * Bump version number * Moved builds to appveyor as artifact repository * Minor update on readme * Added notes about GH releases * Always publish release nuget * Fixed compilation issues with string escaping * Reworked to async test suite and added Karma testrunner for JS tests * Fixed syntax error * Test to set NODE_PATH * Test to set NODE_PATH * Use long test names for JS tests to distinguish them from .net tests * Install chrome-launcher explicitely * Add CHROME_BIN variable to config * Install puppeteer * Removed redundant chrome installation * Small extension on testrunner script * Publish TRX for problem investiation * Formatted error message * Reduced test output * Reorganized tie origin detection for guitar pro files (#206) * Improved tied note support for non stringed instruments on alphaTex (#206) * Minor fix on wrong note ties * Updated documentation regarding tied notes * Fixed unit tests * Reenabled MusicXML tests for parsing and rendering (no content validation yet) * Ensure correct branch name in output files * Fixed MusicXML tests for JS * Reworked slur rendering to really be a slur from one note to another, added special effect slur for hopo/slide slurs, added support for MusicXML slurs (#204) * Modernized layout of player sample and fixed metronome issues (#208, #209) * Update nuget packages and target frameworks * Moved rendering resources to settings including custom font support #215 * Adjusted slur height calculation to be logarithmic, fixed minor display issue of annotation * Added test sdk package * Fixed issue on layout creation * Ensure MSBuild.Sdk.Extras are correctly initialized * Reorganized folder structure for testdata * Added initial set of visual tests for alphaTab * Updated documentation scripts for latest Wyam version * Fixed documentation compilation issue * Enabled unsafe code for release mode * Fixed signature for JS tests * Workaround for buggy SkiaSharp native lib loading * Added missing reference file for tuplet test * Corrected asset link in new help page * Ensure tests are run again * Ensure MSBuild SDK extras are correctly initialized for the .net library * Use UI abstraction on xamarin controls, added missing copyright comments * Added documentation to the public methods and types * Minor change on docs * Reworked tuplet grouping to make beaming prefer tuplet grouping for beaming (fixes #222) * Fixed wrong JsObject serialization that caused cyclic dependency (fixes #224) * Added missing slides to alphaTex (fixes #223) * Added quotes to copy step to overcome issues on spaces in folders * Correctly register mouse events on html element instead of window (fixes #231) * Added tapping effect to alphaTex #225 * Added triplet feel to alphaTex #230 * Changed tap effect to tt as tp is used for tremolo picking * Do not break beams for grace notes * Restore correct font on tab note rendering * Updated reference image after fix on grace note font * Added shorthand notation for tuplets via duration ranges #228 * Extended asserts to accept second parameter * Ensure tuplet is not overwritten (fxies #233) * Minor fix on log level setting #235 * Ensure triplet feel is copied from previous bars #239 * Removed duplicate triplet feel effect on tab configuration (fixes #238) * Added anacrusis parsing for GP formats * Added anacrusis parsing to AlphaTex * Added anacrusis sample to alphaTex docs * Corrected docs to actually use anacrusis * Respect new anacrusis flag on audio generation * Added section parsing to alphaTex (fixes #245) * Added section documentation for alphaTex * Added rendering of section marker * Improved example on sections to eliminate cropping * Update README.md * Calculate discarded samples on pause to synth and seek back in time (fixes 255) * Reworked cursor handling to restart playback on highlighted beat #255 * Changed license info across source * Some code style and formatting. * Fixed compilation issues. * Fixed issue on missing static variable initialization * Various fixes on samples (fixes #271) * Changed null-coalescing as compiler does not handle it yet properly. * Add reference documentation for properties, methods and events (#262) * Added new structure for reference documentation. Updated Wyam * Some small fixes * Added docs for Properties > Core * Added docs for importer * Added docs for JS specific properties * Fixed broken test * Added docs for layout settings * Added docs for player properties * Added docs for rendering resources * Added staves docs * Auto generate rendering resources table, added docs for vibrato * Added docs for core API + some API extension for consistency. * Fixed compilation issues. * Fixed compilation issues. * Docs for player api added. * Moved loadsoundfont to correct section * Docs for the api props * Some type infos for API props * Remove from sidebar again * Docs for jQuery, made jQuery plugin consistent with API * Removed separate jquery docs * Added jQuery event listening to docs. * Added played api methods and docs to be consistent with current version. * Fixed compilation issues * Fixed minor issue and updated player sample after "autoscroll" removal * Add version tag to docs, bump to 0.9.4 * Corrected wrong number * Replaces the current Synthesis Engine by a port of TinySoundFont (#261) * Replaced old synth with TinySoundFont * Fixed some issues on synthesis due to compiler behavior, added copyright notice and thanks to readme for TinySoundFont and SFZero. * Consider mix volume correctly on synthesis, ensure track volumes are correctly initialized. * Added TSF and SFZero info in alphaTab output license header * Fixed compilation issues * Fixed tests * Corrected behavior where initial midi events were re-generated after sequencer finish. * Always execute stop to ensure seek to start * Ensure midi event dispatching does not exceed playback range * Fixed metronome * Fixed issue on GP7 files that midi settings are not correctly loaded. * Pulled public alphaSynth API to main API layer and added docs. (fixes #269) * Introduce consistent rendering and loading API (#272) * Introduced consistent load/render API, removed width configuration from settings * Updated documentation * Introduces ES5 properites and camelCase naming conventions (#273) * Updated compiler to respect new camelCase naming conventions * Some small renames and refactorings to avoid name clashes * Added ES5 property generation to compiler * Fixed some serialization issues on dynamics * Updated documentation pages * Bump version number to indicate bigger change * Updated reference images for visual suite * Adds support for any font as rendering resource (#274) * Added initial forwarding of font sizes to worker * Added font loading check mechanism to workflow to ensure it is loaded before rendering * Integrated dynamic font size generation into already existing workflows * Updated samples and docs * Some cleanup work * Ensure track indexes are initialized correctly if no track list is given (fixes #280) * Ensure metronome volume is not reset to 1 (fixes #279) * Some docs adjusted and events modified * Fixed issue with metronome not hearable all the time (related to #297) * Added new sample using most alphaTab features in a nicer UI * Corrected wrong docs * Ensure initial DOM elements are embedded before render finish events #303 * Add dynamic enable/disable of player and cursor feature (#305) * Added notice that player must be enabled to load soundfonts. * Added dynamic setup/destroy of player and cursors * Add support for triplet feel on audio generation (#306) * Added triplet feel generation for playback (base rules) * Added docs for triplet feel * Added test for triplet feel generation * Updated compiler to fix type check issue * Fix scrolling on mobile devices (#308) * Consolidation of Settings (#307) * Reworked settings structure. * Added new json serialization generation via haxe macro * Added cloning of arrays on serialization * Fixed issues after rebase. * Bump version * Added immutable annotation to handle deserialization accordingly * Adapted serializer generation to be data annotations compatible * Enabled data attribute serialization * Various setting changes to simplify things * Documented breaking changes * Updated docs. * More docs on settings changes. * Ensure songbook mode is fully activated if specified * Updated samples fixed some minor issues * Some docs updates * Updated reference docs on properties. * Polished all prop docs * Create workers via blobs by default (#312) * Switch to blob workers by default * Added polyfill for IE * Fixed wrong repeat group generation for alphaTex (#314) * Disable API docs in favor of Reference docs * Remove decoupling of render result appending (#316) * Fixed jumping on cursor for multi staff setups (#324) * Fixed jumping on cursor for multi staff setups * removed karma CLI as it is not needed anymore * Ensure mix volume is not reset on seeking (#325) * Ensure correct display transposition pitches on alphaTex (#327) * Add dynamics support to alphaTex (#329) * Added support for combined slidein slideout on notes (#330) * Updated data model * Updated importers * Updated midi generator * Updated rendering * Updated docs * Reviewed visual changes and updated test suite * Added docs for css styles (fixes #300) * Improved grace note positioning (#336) * Ignore grace notes for cursor positioning * Consider preceeding beat for grace display positions * Extended visual tests * Precache notes to highlight for multi stave/track note highlighting (#337) * Add support for crescendo and decrescendo in alphaTex (#338) * Added crescendo/decrescendo parsing to alphaTex * Added docs for crescendo * Handle missing startNoteRenderer due to partial renders (#339) * Remember dynamics on alphaTex (fixes #340) * Changed tuplet grouping behavior (#342) * Added activate to playPause to ensure web audio context is active on playback start (#343) * Minor fixes on multi track handling in alphaTex * Reset dynamics on staves and tracks back to default (#346) * Setting to disable default user interaction (#350) * Reintroduce setting to disable default user interaction behavior of alphaTab * Added new events for mouse events on beats * Bump version * Fixed compilation error * Adjusted scroll element selection (#357) * Be more explicit on the usage of templates. * Make logger public * AlphaTab based on TypeScript (#356) * Attempt on 1.0 alpha+latest publish * Update dependencies * Minor WPF fixes (fixes #373) * Slight adjustments on publish scripts for release + adding nuget symbols * Use portable PDBs * New workflow for final tagged release Co-authored-by: Daniel Kuschny <danielku15+gitkraken@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #318
This PR changes 2 parts of the cursor handling: