Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of Accidentals as advertised in Guitar Pro files #381

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Add handling of Accidentals as advertised in Guitar Pro files #381

merged 2 commits into from
Jul 27, 2020

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jul 27, 2020 •
edited
Loading

Resolves #365

This PR has following major changes:

  • Read accidental preference from GPIF.xml (GP7)
  • Add support for Double-Sharp and Double-Flat accidental rendering
  • Adjusted accidental positioning to respect accidentlal width (double flat is wider than others)
  • Quite major rework of accidental and note head line calculation (might need some further testing, tests are green so far)

@Danielku15 Danielku15 self-assigned this Jul 27, 2020
@Danielku15 Danielku15 added this to the 1.1 milestone Jul 27, 2020
@Danielku15 Danielku15 marked this pull request as ready for review July 27, 2020 14:06
@Danielku15 Danielku15 merged commit 34f3ba2 into develop Jul 27, 2020
@Danielku15 Danielku15 deleted the feature/issue365-gp-accidentals branch July 27, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Render accidentals as annotated in Guitar Pro
1 participant
@Danielku15