Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for percussion instruments with 1,2 or 3 lines #382

Merged
merged 27 commits into from
Oct 17, 2020

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Aug 2, 2020

Resolves #94

Changes as part of this PR:

  • Rename members of MusicFontSymbol to match SMuFL element names.
  • Rework of note positioning to use "score line=0" as really the first line
  • Aligned percussion instrument display with Guitar Pro 7 Behavior
  • Adjusted element+variation on data model to midi number based percussion instrument
  • Read Percussion related information from GP7 files.
  • Reading and storing score line related information in data model
  • Rendering of correct score number of lines in ScoreBarRenderer
  • Update positioning of all elements to correctly align items to the rendered score lines.
  • Update midi generation of percussion
  • Ensure all file types still result in correct percussion display and playback.
  • Restore backwards compatibility on element+variation to avoid breaking change
  • Add unit tests and execute performance tests of new rendering logic
  • Update docs (Add docs for percussion instruments alphaTabWebsite#17)

@Danielku15 Danielku15 added area-file-formats Related to supported file formats area-rendering Everything related to the rendering file-format-guitarpro labels Aug 2, 2020
@Danielku15 Danielku15 added this to the 1.1 milestone Aug 2, 2020
@Danielku15 Danielku15 self-assigned this Aug 2, 2020
@Danielku15 Danielku15 marked this pull request as ready for review October 17, 2020 17:34
@Danielku15 Danielku15 merged commit f11d8bb into develop Oct 17, 2020
@Danielku15 Danielku15 deleted the feature/issue94-singlepercussion branch October 17, 2020 17:50
jordanske pushed a commit to jordanske/alphaTab that referenced this pull request Nov 18, 2020
…e#382)

* Reworked data model for percussion elements

* Reworked percussion handling to match GP7 look&feel

* Some test fixes

* Reworked beat effect positioning

* Read percussion line information from GP files

* Replace úsages of getScoreY where a getScoreHeight is needed.

* Adjusted various alignments for new positioning system

* Adjusted rest positioning and stem sizes

* Visual optimizations + helper on tests to compare images

* Revert some visual changes

* Updating test data

* Updated test data and added high DPI upscaling for Html5

* Wip rework positioning

* Updated beaming helper to new positioning

* Read Instrument Articulations from GP files if available.

* Export new model classes.

* Docs

* Remove upscaling

* Add technique symbol reading

* Updated score beaming logic

* Updated test data

* Update midi generation

* Restored correct GP6 percussion mapping

* Compilation and test issues fix

* Restore backwards compatibility with old element/variation system

* Tests and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-file-formats Related to supported file formats area-rendering Everything related to the rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for single percussion instruments.
1 participant