Adds support for percussion instruments with 1,2 or 3 lines #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
added
area-file-formats
# Conflicts: # src/importer/Gp3To5Importer.ts # src/rendering/BarRendererBase.ts # src/rendering/ScoreBarRenderer.ts # src/rendering/glyphs/FlagGlyph.ts # test-data/visual-tests/features/effects-and-annotations/chords.png # test-data/visual-tests/features/effects-and-annotations/pick-stroke.png # test-data/visual-tests/features/general/notation-legend-songbook.png # test-data/visual-tests/features/special-tracks/drum-tabs.png
jordanske
pushed a commit
to jordanske/alphaTab
that referenced
this pull request
Nov 18, 2020
…e#382) * Reworked data model for percussion elements * Reworked percussion handling to match GP7 look&feel * Some test fixes * Reworked beat effect positioning * Read percussion line information from GP files * Replace úsages of getScoreY where a getScoreHeight is needed. * Adjusted various alignments for new positioning system * Adjusted rest positioning and stem sizes * Visual optimizations + helper on tests to compare images * Revert some visual changes * Updating test data * Updated test data and added high DPI upscaling for Html5 * Wip rework positioning * Updated beaming helper to new positioning * Read Instrument Articulations from GP files if available. * Export new model classes. * Docs * Remove upscaling * Add technique symbol reading * Updated score beaming logic * Updated test data * Update midi generation * Restored correct GP6 percussion mapping * Compilation and test issues fix * Restore backwards compatibility with old element/variation system * Tests and cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
Changes as part of this PR:
MusicFontSymbolto match SMuFL element names.