Skip to content

Ensure bend slur is not filled #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/rendering/glyphs/GhostParenthesisGlyph.ts
Original file line number Diff line number Diff line change
@@ -44,6 +44,5 @@ export class GhostParenthesisGlyph extends Glyph {
3
);
}
canvas.fill();
}
}
2 changes: 0 additions & 2 deletions src/rendering/glyphs/ScoreBendGlyph.ts
Original file line number Diff line number Diff line change
@@ -162,7 +162,6 @@ export class ScoreBendGlyph extends ScoreHelperNotesBaseGlyph {
22,
4
);
canvas.fill();
} else {
this.drawBendSlur(
canvas,
@@ -194,7 +193,6 @@ export class ScoreBendGlyph extends ScoreHelperNotesBaseGlyph {
22,
4
);
canvas.fill();
} else {
this.drawBendSlur(
canvas,
3 changes: 0 additions & 3 deletions src/rendering/glyphs/ScoreWhammyBarGlyph.ts
Original file line number Diff line number Diff line change
@@ -197,7 +197,6 @@ export class ScoreWhammyBarGlyph extends ScoreHelperNotesBaseGlyph {
22,
4
);
canvas.fill();
}
break;
case WhammyType.Dive:
@@ -232,7 +231,6 @@ export class ScoreWhammyBarGlyph extends ScoreHelperNotesBaseGlyph {
22,
4
);
canvas.fill();
}
break;
case WhammyType.Dip:
@@ -280,7 +278,6 @@ export class ScoreWhammyBarGlyph extends ScoreHelperNotesBaseGlyph {
22,
4
);
canvas.fill();
}
} else {
let middleX: number = (startX + endX) / 2;
3 changes: 1 addition & 2 deletions src/rendering/glyphs/TieGlyph.ts
Original file line number Diff line number Diff line change
@@ -102,8 +102,6 @@ export class TieGlyph extends Glyph {
4
);
}

canvas.fill();
}
}

@@ -190,6 +188,7 @@ export class TieGlyph extends Glyph {
canvas.quadraticCurveTo(cp1X, cp1Y, x2, y2);
canvas.quadraticCurveTo(cp2X, cp2Y, x1, y1);
canvas.closePath();
canvas.fill();
}

private static readonly BendSlurHeight: number = 11;
Binary file modified test-data/visual-tests/notation-legend/bends-default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test-data/visual-tests/notation-legend/full-default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.