Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Guitar Pro 7 Exporter #447

Merged
merged 31 commits into from
Dec 30, 2020
Merged

Add Guitar Pro 7 Exporter #447

merged 31 commits into from
Dec 30, 2020

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 30, 2020 •
edited
Loading

Issues

Fixes #443

Proposed changes

  • New classes for exporting Score instances to Guitar Pro 7.
  • Handling of Program/Sound Changes in GP7
  • Upgrade of visual test suite to GP7 files

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Setup Base Structure
  • Add XML Writer
  • Add Zip Writer
  • Write BinaryStylesheet
  • Write GPIF
  • Write PartConfiguration
  • Existing builds tests pass
  • New tests were added
  • Fix C# version
  • Test/Validate generated files with Guitar Pro
  • Test format conversion scenarios (alphaTex -> GP7, GPX -> GP7)
  • Performance optimization
  • Add Deflate for compressed zip (might be skipped)

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 30, 2020
@Danielku15 Danielku15 marked this pull request as ready for review December 30, 2020 15:03
@Danielku15 Danielku15 marked this pull request as draft December 30, 2020 15:04
@Danielku15 Danielku15 marked this pull request as ready for review December 30, 2020 21:52
@Danielku15 Danielku15 merged commit 7e5a7a5 into develop Dec 30, 2020
@Danielku15 Danielku15 deleted the feature/gp7-export branch December 30, 2020 22:44
This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guitar Pro 7 Exporter
1 participant
@Danielku15