Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework JSON Serialization mechanism for Data Model #466

Merged
merged 19 commits into from
Dec 27, 2020

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Dec 17, 2020

Issues

Fixes #461

Proposed changes

This PR reworks the internal JSON serialization mechanism for the data model. Instead of having the manually maintained serializer, we reuse the JSON serializer from the settings. Changes consist of

  • Replace manually maintained copyTo and cloning system
  • Replace manual Score JSON serialization with auto-generated one
  • Include and Extend TS Clone and JSON Transformers for C# generation

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added
  • Write code docs
  • Performance tests and improvements (also build chain)
  • Double check old json vs. new json to avoid missing details

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

Sorry, something went wrong.

@Danielku15 Danielku15 self-assigned this Dec 17, 2020
@Danielku15 Danielku15 marked this pull request as ready for review December 27, 2020 17:23
@Danielku15 Danielku15 merged commit 0b07e0c into develop Dec 27, 2020
@Danielku15 Danielku15 deleted the feature/json-model branch December 27, 2020 17:32
This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON serialization in .net
1 participant