Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntersectionObserver for initial load and lazy loading #515

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Add IntersectionObserver for initial load and lazy loading #515

merged 1 commit into from
Jan 10, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #510

Proposed changes

  1. Replaces the old timer based visibility checker with the IntersectionObserver
  2. Replaces the getBoundingClientRect based lazy loading system with the IntersectionObserver

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 10, 2021
@Danielku15 Danielku15 force-pushed the feature/intersection-observer branch from 1ef672c to 4d9dde8 Compare January 10, 2021 19:01
@Danielku15 Danielku15 force-pushed the feature/intersection-observer branch from 4d9dde8 to ace7f9f Compare January 10, 2021 19:05
@Danielku15 Danielku15 merged commit e518b86 into develop Jan 10, 2021
@Danielku15 Danielku15 deleted the feature/intersection-observer branch January 10, 2021 19:10
This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Intersection Observer API for better performance
1 participant
@Danielku15