Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle node.js environment correctly #544

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Handle node.js environment correctly #544

merged 2 commits into from
Feb 13, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #542

Proposed changes

Adds some checks to detect node.js and avoids accessing browser specific APIs.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Feb 13, 2021
@Danielku15 Danielku15 merged commit a9f84fb into develop Feb 13, 2021
@Danielku15 Danielku15 deleted the feature/node-js branch February 13, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AlphaTab should be available on node.js
1 participant
@Danielku15