Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully destroy alphaTab player #595

Merged
merged 3 commits into from
May 8, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #594

Proposed changes

Extends the destroy sequence to first shutdown the synth output.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this May 8, 2021
@Danielku15 Danielku15 force-pushed the feature/shutdown-output-on-destroy branch from c488551 to 717a912 Compare May 8, 2021 10:31
@Danielku15 Danielku15 merged commit 08d8285 into develop May 8, 2021
@Danielku15 Danielku15 deleted the feature/shutdown-output-on-destroy branch May 8, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web audio stuck after api.destroy()
1 participant