Use HTML5 AudioWorklet beside ScriptProcessor for passing audio. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #480
Proposed changes
Try to use HTML5 Audio Worklets if available for audio output instead of the
ScriptProcessor.So far it is a simple copy-paste of the old output implementation with the required adaptions. So far only the output is shifted to the worklet, we'll have to check if more offloading from the UI thread is possible as currently the synthesizing happens in a worker and all communication between worklet and WebWorker go via UI thread.
Checklist
Further details