Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio worklets in safari #652

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Fix audio worklets in safari #652

merged 1 commit into from
Aug 22, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #646

Proposed changes

Safari does not allow accessing the members of AudioWorkletGlobalScope through globalThis even though it provides it. It results in errors to do so. Therefore we need to ensure in alphaTab to not use globalThis to access the sampleRate and registerProcessor.

Using globalThis results in errors like:

TypeError: Can only call AudioWorkletGlobalScope.registerProcessor on instances of AudioWorkletGlobalScope

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 22, 2021
@Danielku15 Danielku15 merged commit 639c56f into develop Aug 22, 2021
@Danielku15 Danielku15 deleted the feature/safari-worklet branch August 22, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback of the audioworklets version doesn't work in Safari 14.1
1 participant