Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework exports to allow using classes in type hints #684

Merged
merged 3 commits into from
Nov 28, 2021

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Nov 28, 2021

Issues

Fixes #682

Proposed changes

Rework "namespaces" to be organized through module re-exports instead of const variables. On the way I cleaned the imports to use consistently the @src absolute paths. Also a small fix in the Rollup resolver was needed to get the index module imports working.

Related to the issue I reported here.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 28, 2021
@Danielku15 Danielku15 merged commit bc2f9de into develop Nov 28, 2021
@Danielku15 Danielku15 deleted the feature/ts-imports branch November 28, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Use Models in Typescript Project
1 participant