Clear buffered samples on audio settings change #686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #657
Proposed changes
We need to reset the already buffered audio in case we make any audio related changes like muting tracks or changing volumes. Otherwise it can take a while until it gets applied.
We do this clearing by simply seeking to the currently known time position. This will clear anything in the output buffers and trigger a regeneration of the audio.
Checklist
Further details