Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear buffered samples on audio settings change #686

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #657

Proposed changes

We need to reset the already buffered audio in case we make any audio related changes like muting tracks or changing volumes. Otherwise it can take a while until it gets applied.

We do this clearing by simply seeking to the currently known time position. This will clear anything in the output buffers and trigger a regeneration of the audio.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Nov 28, 2021
@Danielku15 Danielku15 merged commit 3ba6656 into develop Nov 28, 2021
@Danielku15 Danielku15 deleted the feature/audio-settings-delay branch November 28, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting update becomes laggy
1 participant