Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findNoteAtPos logic #746

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

gallegretti
Copy link
Contributor

Issues

Fixes #744

Proposed changes

Fixes logic on findNoteAtPos to correctly find the expected note. Here is a simple codepen demonstrating the fix:
https://codepen.io/gallegretti/pen/KKyqypL
As you click on the notes, the ids will be logged on the console

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

Sorry, something went wrong.

(cherry picked from commit 31b9362)
@Danielku15 Danielku15 merged commit 4407997 into CoderLine:develop Feb 12, 2022
@Danielku15
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad detection of a note selection on BeatBounds
2 participants