Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear various settings during print to avoid double print. #846

Merged
merged 1 commit into from
May 7, 2022

Conversation

Danielku15
Copy link
Member

Issues

Fixes #844

Proposed changes

Actually #844 had a wrong assumption that we have double render events on load. But this problem was already addressed in 1.3 and it is not reproducible anymore. But we had the issue that during print we do not clear some settings which must be cleared for printing. Due to this we first rendered the tracks as displayed currently, and then the default file loading kicked in and rendered it again.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this May 7, 2022
@Danielku15 Danielku15 merged commit 310f65a into develop May 7, 2022
@Danielku15 Danielku15 deleted the feature/double-print branch May 7, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render related events should not fire on initial empty render
1 participant