Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle first MasterBar Tempo changes correctly #994

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Handle first MasterBar Tempo changes correctly #994

merged 2 commits into from
Oct 2, 2022

Conversation

Danielku15
Copy link
Member

Issues

Fixes #988

Proposed changes

  1. Ensure we update the score.tempo when we parse the first masterbar in MusicXML
  2. Ensure we respect tempo changes from score.tempo in the first masterbar.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Oct 2, 2022
@Danielku15 Danielku15 marked this pull request as ready for review October 2, 2022 12:22
@Danielku15 Danielku15 changed the title Handle first MasterBar Tempo changes correctls Handle first MasterBar Tempo changes correctly Oct 2, 2022
@Danielku15 Danielku15 merged commit ae82b7c into develop Oct 2, 2022
@Danielku15 Danielku15 deleted the feature/musicxml-tempo branch October 2, 2022 12:35
ChiHoc pushed a commit to ChiHoc/alphaTab that referenced this pull request Nov 7, 2022
@Danielku15 @ChiHoc
Handle first MasterBar Tempo changes correctly (CoderLine#994)
7a4e3ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong tempo for first measure in MusicXML file format.
1 participant
@Danielku15